Arik Hadas has posted comments on this change. Change subject: engine: scheduling host- find free VF ......................................................................
Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/37931/6//COMMIT_MSG Commit Message: Line 8: Line 9: A VF is marked as suitable for a passthrough vnic in case: Line 10: 1. It is free (reported by vdsCaps, not attached to vm, doesn't have vlan Line 11: device or network attached to it). Line 12: 2. It's PF has the vnic's network (or label) in it's vf's configuration. s/It's/Its Line 13: Line 14: Change-Id: I58c7aaa7a5a7160132418c397840583209aa8371 https://gerrit.ovirt.org/#/c/37931/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 111: Line 112: private Guid cachedActiveIsoDomainId; Line 113: private boolean needsHostDevices = false; Line 114: Line 115: private Map<Guid, String> passthroughVnicToVfMap = new HashMap<>(); Can we encapsulate this thing in hostNicVfsConfigHelper instead of having it as a member of this command? I mean, the scheduler updates hostNicVfsConfigHelper with this information so instead of getting it directly from the scheduler, can we query it from hostNicVfsConfigHelper ? Line 116: Line 117: public static final String ISO_PREFIX = "iso://"; Line 118: public static final String STATELESS_SNAPSHOT_DESCRIPTION = "stateless snapshot"; Line 119: Line 252: // re-throw it. otherwise, continue (the vm will be down and a re-run will be triggered) Line 253: switch (e.getErrorCode()) { Line 254: case Done: // should never get here with errorCode = 'Done' though Line 255: case exist: Line 256: cleanupPassthroughVnics(); > you might want to re-think where you put this cleanup, currently it looks l +1 Line 257: reportCompleted(); Line 258: throw e; Line 259: case VDS_NETWORK_ERROR: // probably wrong xml format sent. Line 260: case PROVIDER_FAILURE: -- To view, visit https://gerrit.ovirt.org/37931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58c7aaa7a5a7160132418c397840583209aa8371 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
