Allon Mureinik has posted comments on this change. Change subject: core: Remove constant SIZE_IS_NOT_AVAILABLE ......................................................................
Patch Set 16: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/39004/16/packaging/dbscripts/upgrade/03_06_1170_update_repo_file_metadata_size.sql File packaging/dbscripts/upgrade/03_06_1170_update_repo_file_metadata_size.sql: Line 1: ALTER TABLE repo_file_meta_data ALTER COLUMN size set DEFAULT NULL; if you ever rebase this, "set" should also be in upper case ("SET") Line 2: Line 3: UPDATE repo_file_meta_data Line 4: SET size = null Line 1: ALTER TABLE repo_file_meta_data ALTER COLUMN size set DEFAULT NULL; Line 2: Line 3: UPDATE repo_file_meta_data Line 4: SET size = null As well as "null" -- To view, visit https://gerrit.ovirt.org/39004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida18353f1d5c976ee70e65045b80410dded2bb1f Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
