Allon Mureinik has posted comments on this change.

Change subject: core: Remove constant SIZE_IS_NOT_AVAILABLE
......................................................................


Patch Set 15: Code-Review-1

(1 comment)

Missing: upgrade script to perform the change you made to the fixtures on 
preexisting customers' data.

https://gerrit.ovirt.org/#/c/39004/15/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java:

Line 54:     }
Line 55: 
Line 56:     private void createDefaultFileStats(Object[] fileNames) {
Line 57:         for (int i = 0; i < fileNames.length; i++) {
Line 58:             fileStats.put((String) fileNames[i], Collections.<String, 
Object>emptyMap());
Formatting: "Collections.<String, Object> emptyMap()"
Line 59:         }
Line 60:     }
Line 61: 
Line 62:     public Map<String, Map<String, Object>> getFileStats() {


-- 
To view, visit https://gerrit.ovirt.org/39004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida18353f1d5c976ee70e65045b80410dded2bb1f
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to