Allon Mureinik has posted comments on this change. Change subject: core: Change auto-recovery code for storage domains ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) wording issues, see inline. .................................................... Commit Message Line 5: CommitDate: 2012-09-19 18:31:45 +0300 Line 6: Line 7: core: Change auto-recovery code for storage domains Line 8: Line 9: Because of change which were done at error storage flows s/were/was Line 10: no need for activate of storage domain in auto-recovery, when domain will be Line 11: seen by vdsm it will be automaticlly switched to Active status. Line 12: These is possible because of no more disconnect and deactivate is Line 13: send when domain in error state. Line 6: Line 7: core: Change auto-recovery code for storage domains Line 8: Line 9: Because of change which were done at error storage flows Line 10: no need for activate of storage domain in auto-recovery, when domain will be s/no/these is no/ s/activate of/activating/ Line 11: seen by vdsm it will be automaticlly switched to Active status. Line 12: These is possible because of no more disconnect and deactivate is Line 13: send when domain in error state. Line 14: At any case we will try to reconnect storage domain if it was disconnected. -- To view, visit http://gerrit.ovirt.org/8015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04f25dca8888b19711a840aed150227437972d65 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
