Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: fix for python 2.6 ......................................................................
Patch Set 2: one byte shorter, a few nano-seconds faster... fine with me. As I wrote in [1], I am not used to this syntax. repr(set((0,))) returns 'set([0])', that's what I am personally used to. Simone's patch made me write the same here, I guess I'll now quickly return to my (bad? old?) habits. [1] https://gerrit.ovirt.org/#/c/38811/9/src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py@103 -- To view, visit https://gerrit.ovirt.org/39427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide1164ca2a404f67b46ff906a96ec70f4519d8b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Barak Korren <bkor...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
