Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: fix for python 2.6 ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39427/1/packaging/setup/ovirt_engine_setup/engine_common/database.py File packaging/setup/ovirt_engine_setup/engine_common/database.py: Line 692: if stdout is not None: Line 693: stdout.close() Line 694: Line 695: self.logger.debug('db backup res %s' % res) Line 696: if set([r['rc'] for r in res['result']]) != set([0]): > you can probably drop the square brackets on the right hand side and just p Done Line 697: raise RuntimeError( Line 698: _( Line 699: 'Failed to backup database, please check ' Line 700: 'the log file for details' -- To view, visit https://gerrit.ovirt.org/39427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide1164ca2a404f67b46ff906a96ec70f4519d8b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Barak Korren <bkor...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
