Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: Alert if volume snapshot max soft limit reached
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/39231/3/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java:

Line 193: 
Line 194:             if (config != null) {
Line 195:                 // remove the % sign in the last
Line 196:                 String configValue = config.getParamValue();
Line 197:                 if (configValue.endsWith("%")) {
> can be replaced with   
Done
Line 198:                     configValue = configValue.substring(0, 
configValue.length() - 1);
Line 199:                 }
Line 200:                 int snapMaxSoftLimitPcnt = 
Integer.parseInt(configValue);
Line 201: 


-- 
To view, visit https://gerrit.ovirt.org/39231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96ad64aa30a674bdc2c72e617fc71e13854fab85
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to