Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Alert if volume snapshot max soft limit reached ......................................................................
Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/39231/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java: Line 92: > can this be combined to single method? Because in both methods you are call Actually the second method checkAndRemoveVolumeSnapshotSoftLimitAlert only is called from BLLs so kept is separate. https://gerrit.ovirt.org/#/c/39231/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java: Line 54: import org.w3c.dom.Element; Line 55: import org.w3c.dom.Node; Line 56: import org.w3c.dom.NodeList; Line 57: Line 58: public class GlusterUtil { > this class is a good candidate to be injected by the CDI, and annotated by Will send separate patch for making this class a singleton one. Hope that is fine. Line 59: private static GlusterUtil instance = new GlusterUtil(); Line 60: private Logger log = LoggerFactory.getLogger(getClass()); Line 61: private static final int SSH_PORT = 22; Line 62: private static final String PEER = "peer"; https://gerrit.ovirt.org/#/c/39231/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AlertDirector.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AlertDirector.java: Line 60: static > method name should start with lowerCase Done https://gerrit.ovirt.org/#/c/39231/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java: Line 196: > I think you should strip the % sign only if present. What if gluster change Done https://gerrit.ovirt.org/#/c/39231/2/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java: Line 415: > expected should be first argument Done -- To view, visit https://gerrit.ovirt.org/39231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96ad64aa30a674bdc2c72e617fc71e13854fab85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
