Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/37886/15/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 57: usage = "__single__"; Line 58: } else { Line 59: usage = args.remove(0); Line 60: argMap.put("__action__", usage); Line 61: } > The caller choice is in this case for example 'logrecord' so I use logrecor no, you do not need subsection. you just run the parser again... every iteration you use different prefix to parse the others. first iteration you use the core prefix extract module name, then you use the module name as prefix and extract the action name then you use the action name as prefix, ... Line 62: if(usage.equals("--help") || (!usage.equals("__single__") && !args.isEmpty() && args.contains("--help"))) { Line 63: throw new ExitException(getHelp(), 0, true); Line 64: } Line 65: -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
