Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 16: (3 comments) https://gerrit.ovirt.org/#/c/37886/16/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java: Line 89: String.format( Line 90: "usage: %s%n%n%s%n%n%s", Line 91: ((String)args.get("__usage__")).replace("@PROGRAM_NAME@", programName), Line 92: (String)args.get("__help__"), Line 93: (String)args.get("__underlinetext__") > Because I "lost" reference to ParametersParser class once parserArguments i I do not see a reason to lose the reference. Line 94: ) Line 95: ); Line 96: if(args.containsKey("__modules__")) { Line 97: System.out.println( https://gerrit.ovirt.org/#/c/37886/16/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ModuleService.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ModuleService.java: Line 13: public String getName(); Line 14: Line 15: public String getDescription(); Line 16: Line 17: public Map<String, Object> getArguments(); > As I wrote in previous class. This is an way how to access all information but you do not actually need this, we agreed to just display the module list in usage of core, so module can take care of its own usage. Line 18: Line 19: public boolean doHelp(); Line 20: Line 21: public void setContext(ExtMap context); Line 21: public void setContext(ExtMap context); Line 22: Line 23: public ExtMap getContext(); Line 24: Line 25: public void parseArguments(List<String> argsList, String prefix) throws Exception; > asi it wishes? How it could then know what args are wrong and what are corr we the module should parse its own parameters, we talked about this, 3 part parsing, using different properties/prefix. Line 26: Line 27: public void run(String action) throws Exception; Line 28: -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
