Maor Lipchuk has posted comments on this change.

Change subject: core: support Cinder disk removal
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/39196/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java:

Line 241:     USER_MOVED_VM_DISK(2008),
Line 242:     USER_FAILED_MOVED_VM_DISK(2009, AuditLogSeverity.ERROR),
Line 243:     USER_MOVED_VM_DISK_FINISHED_SUCCESS(2010),
Line 244:     USER_MOVED_VM_DISK_FINISHED_FAILURE(2011, AuditLogSeverity.ERROR),
Line 245:     USER_REMOVE_DISK_INITIATED(2038),
The number here is not sequential
Line 246:     USER_FINISHED_REMOVE_DISK(2014),
Line 247:     USER_FINISHED_FAILED_REMOVE_DISK(2015, AuditLogSeverity.WARNING),
Line 248:     USER_FINISHED_REMOVE_DISK_NO_DOMAIN(2012),
Line 249:     USER_FINISHED_FAILED_REMOVE_DISK_NO_DOMAIN(2013, 
AuditLogSeverity.WARNING),


-- 
To view, visit https://gerrit.ovirt.org/39196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9006a1c3fa2e531d0fb21498267620d3bcf64882
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to