Daniel Erez has posted comments on this change. Change subject: core: support Cinder disk removal ......................................................................
Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/39196/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-25 18:56:24 +0200 Line 4: Commit: Daniel Erez <de...@redhat.com> Line 5: CommitDate: 2015-03-25 21:08:07 +0200 Line 6: Line 7: core: support Cinder disk removal > Remove redundant space Done Line 8: Line 9: Added RemoveCinderDiskCommand and RemoveCinderDiskCallback. Line 10: Line 11: Change-Id: I9006a1c3fa2e531d0fb21498267620d3bcf64882 https://gerrit.ovirt.org/#/c/39196/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java: Line 43: if (disk.getImageStatus() == ImageStatus.ILLEGAL) { Line 44: // Remove disk from DB Line 45: setCommandStatus(CommandStatus.SUCCEEDED); Line 46: } Line 47: else { > Please use the same line Done Line 48: // Remove disk from Cinder Line 49: ImagesHandler.updateImageStatus(disk.getId(), ImageStatus.LOCKED); Line 50: getCinderBroker().deleteDisk(disk); Line 51: } https://gerrit.ovirt.org/#/c/39196/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java: Line 17: Line 18: @Override Line 19: public void doPolling(Guid cmdId, List<Guid> childCmdIds) { Line 20: super.doPolling(cmdId, childCmdIds); Line 21: > Please remove empty line Done Line 22: CinderBroker cinderBroker = getCinderBroker(); Line 23: if (!cinderBroker.isDiskExist(getDiskId())) { Line 24: // Disk has been deleted successfully Line 25: getCommand().setCommandStatus(CommandStatus.SUCCEEDED); Line 40: Line 41: @Override Line 42: public void onFailed(Guid cmdId, List<Guid> childCmdIds) { Line 43: super.onFailed(cmdId, childCmdIds); Line 44: > Please remove empty line Done Line 45: log.error("Failed deleting disk from Cinder. ID: {}", getDiskId()); Line 46: if (getCommand().getParameters().getShouldBeLogged()) { Line 47: new AuditLogDirector().log(getCommand(), AuditLogType.USER_FINISHED_FAILED_REMOVE_DISK); Line 48: } Line 54: Line 55: @Override Line 56: public void onSucceeded(Guid cmdId, List<Guid> childCmdIds) { Line 57: super.onSucceeded(cmdId, childCmdIds); Line 58: > Please remove empty line Done Line 59: log.info("Disk has been successfully deleted from Cinder. ID: {}", getDiskId()); Line 60: if (getCommand().getParameters().getShouldBeLogged()) { Line 61: new AuditLogDirector().log(getCommand(), AuditLogType.USER_FINISHED_REMOVE_DISK); Line 62: } -- To view, visit https://gerrit.ovirt.org/39196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9006a1c3fa2e531d0fb21498267620d3bcf64882 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
