Vojtech Szocs has posted comments on this change. Change subject: build: pack gwt-symbols within jar ......................................................................
Patch Set 2: Sorry for late response, I wanted to review yesterday but left earlier than expected. The patch looks good. AFAIK, the limitation Alon refers to is that current RHEL build picks up only some files (war, jar etc.) so we need to create some archive containing the symbol maps as jar file. The symbol maps are an optional package that users can install and provide us when facing UI errors. Not sure if <dependencies> in frontend-symbols/pom.xml is needed at all (due to using resource copying) but overall looks good. -- To view, visit https://gerrit.ovirt.org/39118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I489c154859d2092c844d6798a339959baa63a0ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
