Alon Bar-Lev has posted comments on this change. Change subject: build: pack gwt-symbols within jar ......................................................................
Patch Set 1: > I'm also lost. Reading the BZ helped. > > > due to limitation of rhel build, gwt target files are not > available to the make process. > > What limitations of RHEL? Do you mean RHEV? What gwt target files > do you need? Just the .symbolMap files? this what was written in the bug... see last note. > > packing these as maven artifacts will enable to reference them. > > "these" means GWT target files, aka symbolMaps? reference from > where, and why? Just ad hoc when something needs to be debugged? yes, why? you guys should know... > > somewhat more complex, until we drop el6. > > more complex than what? no, we can revert back to how it was. > So it sounds like the goal of this patch is to package up GWT > compiler output (symbolMaps) and deliver it with the application > for unknown future debugging use. Makes sense. > > What do the .keep files do? so that zip/jar file will b none empty and always contain the root directories for symbols, this is to allow BUILD_GWT=0 and still be able to package correctly. also unzip has bad nature of return with error when not extracting any file. -- To view, visit https://gerrit.ovirt.org/39118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I489c154859d2092c844d6798a339959baa63a0ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
