Martin Mucha has posted comments on this change. Change subject: core: Explicit type can be replaced with <> applied ......................................................................
Patch Set 2: how did I do this: I don't know which IDE you're using, but I use intellij. There, if there's some hint in code, you place cursor on that place and press alt-enter (maybe different shortcut), and among offered action there's "run inspection on". You select module and proceed. This is fix for 2 minutes. There are LOT of files cluttered with errors, this way we can cure them quite fast nad quite lot. And we should do that, since true errors can be hiding among false ones. ad scripts: I'd try not to use any home-brewed scripts for big changes, since the chance of making error, however anyone good at regex is, is not super-small and is not worth it. Now. Split lines. There were split, because they were long, but they're not now¹. I agree that it looks weird, but there are 224 modified files, it's not worth it going through all of them I think. And we cannot run code formatter on all of them(lot (most?) of code is not 100% formatted), and we even cannot run code formatter only on modified lines (since whole expression is not on sole line). This unneeded type declaration bothers me all the time, so I'm willing to go over those 224 patches, but I'd rather go along different path. If anyone hadn't read "clean code" book, I highly recommend it. There's one rule mentioned: leave your 'area' cleaner than it was when you came. Applied: there was some problems in those areas. This patches does some cleanup, but not whole, but it's lot better I think. Lets leave rest of the problems for future visitors of those areas. If everybody cleans method they're working on, we'll be soon out of all problems in all classes we have to work with. I've been able to narrow down 'problems' to 28 files, so I'm fixing those, but the rest I'd like to leave as it is after automatic fixes. [1] namely because we're sometimes using types like Map<Guid, LinkedList<Pair<Event, FutureTask<EventResult>>>> -- To view, visit https://gerrit.ovirt.org/38706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cc0b8832bae7bc1a78119a98e3bd7ef156fe897 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
