Yevgeny Zaspitsky has posted comments on this change. Change subject: core: Explicit type can be replaced with <> applied ......................................................................
Patch Set 1: (1 comment) Very much appreciated patch! Making our code clean of those yellow signs make easier to find sever warnings being reported by IDEs. The only improvement I see here is that after the refactoring there are some split lines with no visible reason for that and now look weird. I added the comment as an example for that. BTW, how did you find all those places? What kind of script did you use? https://gerrit.ovirt.org/#/c/38706/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJob.java: Line 143: } Line 144: Line 145: private Map<ServiceType, GlusterServiceStatus> createServiceTypeStatusMap(List<Map<String, GlusterServiceStatus>> serviceStatusMaps) { Line 146: Map<ServiceType, GlusterServiceStatus> fetchedServiceTypeStatusMap = Line 147: new HashMap<>(); please join the lines Line 148: for (Entry<String, GlusterServiceStatus> entry : mergeServiceStatusMaps(serviceStatusMaps).entrySet()) { Line 149: String serviceName = entry.getKey(); Line 150: GlusterServiceStatus status = entry.getValue(); Line 151: ServiceType type = getServiceNameMap().get(serviceName).getServiceType(); -- To view, visit https://gerrit.ovirt.org/38706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cc0b8832bae7bc1a78119a98e3bd7ef156fe897 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
