anmolbabu has posted comments on this change. Change subject: engine : Bll Command for Create Geo Rep session ......................................................................
Patch Set 31: (4 comments) https://gerrit.ovirt.org/#/c/29834/31/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java: Line 58: if (slaveVolume.getStatus() != GlusterStatus.UP) { Line 59: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_SHOULD_BE_STARTED); Line 60: } Line 61: slaveHost = getSlaveHost(); Line 62: if (slaveHost == null) { > I hope you might need the host to be UP as well? Done Line 63: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NOT_EXIST); Line 64: } Line 65: if (!areAllRemoteServersUp()) { Line 66: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_ONE_OR_MORE_REMOTE_HOSTS_ARE_NOT_ACCESSIBLE); https://gerrit.ovirt.org/#/c/29834/31/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 436: GLUSTER_VOLUME_SNAPSHOT_RESCHEDULE_FAILED(4137, AuditLogSeverity.ERROR), Line 437: CREATE_GLUSTER_BRICK(4138), Line 438: CREATE_GLUSTER_BRICK_FAILED(4139), Line 439: GEO_REP_PUB_KEY_FETCH_FAILED(4140, AuditLogSeverity.ERROR), Line 440: GET_PUB_KEY(4141), > GLUSTER prefix? Done Line 441: GLUSTER_GEOREP_PUBLIC_KEY_WRITE_FAILED(4142, AuditLogSeverity.ERROR), Line 442: WRITE_PUB_KEYS(4143), Line 443: GLUSTER_GEOREP_SETUP_MOUNT_BROKER_FAILED(4144, AuditLogSeverity.ERROR), Line 444: SETUP_GEOREP_MOUNT_BROKER(4145), Line 438: CREATE_GLUSTER_BRICK_FAILED(4139), Line 439: GEO_REP_PUB_KEY_FETCH_FAILED(4140, AuditLogSeverity.ERROR), Line 440: GET_PUB_KEY(4141), Line 441: GLUSTER_GEOREP_PUBLIC_KEY_WRITE_FAILED(4142, AuditLogSeverity.ERROR), Line 442: WRITE_PUB_KEYS(4143), > same here Done Line 443: GLUSTER_GEOREP_SETUP_MOUNT_BROKER_FAILED(4144, AuditLogSeverity.ERROR), Line 444: SETUP_GEOREP_MOUNT_BROKER(4145), Line 445: GLUSTER_GEOREP_SESSION_CREATE_FAILED(4146, AuditLogSeverity.ERROR), Line 446: CREATE_GLUSTER_VOLUME_GEOREP_SESSION(4147), https://gerrit.ovirt.org/#/c/29834/31/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/UpdateGlusterHostPubKeyToSlaveParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/UpdateGlusterHostPubKeyToSlaveParameters.java: Line 17: super(); Line 18: } Line 19: Line 20: public UpdateGlusterHostPubKeyToSlaveParameters(Guid vdsId, List<String> pubKeys) { Line 21: this(vdsId, pubKeys, "root"); > may want to externalise to constants..in a separate patch maybe? removed its initialisation as it is optional and can be null Line 22: } Line 23: Line 24: public UpdateGlusterHostPubKeyToSlaveParameters(Guid vdsId, List<String> pubKeys, String remoteUserName) { Line 25: super(vdsId); -- To view, visit https://gerrit.ovirt.org/29834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccc92235deea42d7818336b2402476193cbe789c Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
