Kanagaraj M has posted comments on this change.

Change subject: engine : Bll Command for Create Geo Rep session
......................................................................


Patch Set 31:

(3 comments)

https://gerrit.ovirt.org/#/c/29834/31/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java:

Line 62: slaveHost
I hope you might need the host to be UP as well?

May be applicable only when this host doesn't have bricks


https://gerrit.ovirt.org/#/c/29834/31/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java:

Line 436:     GLUSTER_VOLUME_SNAPSHOT_RESCHEDULE_FAILED(4137, 
AuditLogSeverity.ERROR),
Line 437:     CREATE_GLUSTER_BRICK(4138),
Line 438:     CREATE_GLUSTER_BRICK_FAILED(4139),
Line 439:     GEO_REP_PUB_KEY_FETCH_FAILED(4140, AuditLogSeverity.ERROR),
Line 440:     GET_PUB_KEY(4141),
GLUSTER prefix?
Line 441:     GLUSTER_GEOREP_PUBLIC_KEY_WRITE_FAILED(4142, 
AuditLogSeverity.ERROR),
Line 442:     WRITE_PUB_KEYS(4143),
Line 443:     GLUSTER_GEOREP_SETUP_MOUNT_BROKER_FAILED(4144, 
AuditLogSeverity.ERROR),
Line 444:     SETUP_GEOREP_MOUNT_BROKER(4145),


Line 442: WRITE_PUB_KEYS
same here


-- 
To view, visit https://gerrit.ovirt.org/29834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccc92235deea42d7818336b2402476193cbe789c
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to