Martin Peřina has posted comments on this change. Change subject: core: Refactor FenceVdsVDSCommand return value ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/38062/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java: Line 55: _result > agree with 1) 1) Done 2) This is easy to achieve for JSONRPC, but problematic for XMLRPC, because too many things are hard coded in XMLRPC. Basically all VDSM verbs returns ancestor of StatusForXmlRpc object, which is converted in *VDSCommand objects to desired result. So I would leave this optimization out until we drop XMLRPC support -- To view, visit https://gerrit.ovirt.org/38062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b3ada18bb36a376c5c19327461d2daa53eedc59 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
