Martin Peřina has posted comments on this change. Change subject: core: Refactor FenceVdsVDSCommand return value ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/38062/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceOperationResult.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceOperationResult.java: Line 2: Line 3: /** Line 4: * Result of action performed on single fence agent Line 5: */ Line 6: public class FenceOperationResult { > equals and hash code? I may overwrite equals and hashcode, but I don's see any real use case which would require those overridden methods. I never compare just results and logic for evaluating results is usually complex, so this class is just a placeholder for its attributes. Line 7: /** Line 8: * Operation result Line 9: */ Line 10: private final Status status; -- To view, visit https://gerrit.ovirt.org/38062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b3ada18bb36a376c5c19327461d2daa53eedc59 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
