Ramesh N has posted comments on this change. Change subject: webadmin : Create Geo-rep pop up ......................................................................
Patch Set 38: (5 comments) https://gerrit.ovirt.org/#/c/29691/38/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java: Line 70: vdcQueryParametersBase Please give a better name. https://gerrit.ovirt.org/#/c/29691/38/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 244: else if (command.getName().equalsIgnoreCase("closeConfirmWindow")) {//$NON-NLS-1$ : setConfirmWindow(null); You can remove this as this is already being handled in the end. Line 402: Line 403: GlusterVolumeEntity selectedMasterVolume = getEntity(); Line 404: Line 405: final GlusterVolumeGeoRepCreateModel geoRepCreateModel = Line 406: new GlusterVolumeGeoRepCreateModel(selectedMasterVolume); Set HasName and HelpTag for the model. Line 407: setWindow(geoRepCreateModel); Line 408: Line 409: geoRepCreateModel.getShowEligibleVolumes().setEntity(true); Line 410: https://gerrit.ovirt.org/#/c/29691/38/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Remove file formatting related changes from the patch Line 1: package org.ovirt.engine.ui.uicommonweb.models.volumes; Line 2: Line 3: import java.util.ArrayList; Line 4: import java.util.Arrays; Line 516: allowCreateGeoRepSession = false; not required as by default it is initialized to false -- To view, visit https://gerrit.ovirt.org/29691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied7317d456bf66db9a7800ba7106f2e8ec66429c Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
