Greg Sheremeta has posted comments on this change.

Change subject: userportal,webadmin: multiple login messages
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/38214/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.ui.xml
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.ui.xml:

Line 64:                     <g:Image styleName="obrand_loginFormLogoImage" 
url="clear.cache.gif" />
Line 65:                 </b:Column>
Line 66: 
Line 67:                 <b:Alert type="DANGER" addStyleNames="col-sm-11" 
ui:field="errorMessagePanel">
Line 68:                     <g:HTMLPanel tag="span" 
addStyleNames="pficon-layered {style.information-triangle}">
this one's my bad -- please rename 'information-triangle' to 'icon' or 
something generic.
Line 69:                         <g:HTMLPanel tag="span" addStyleNames="pficon 
pficon-error-octagon"></g:HTMLPanel>
Line 70:                         <g:HTMLPanel tag="span" addStyleNames="pficon 
pficon-error-exclamation"></g:HTMLPanel>
Line 71:                     </g:HTMLPanel>
Line 72:                 </b:Alert>


-- 
To view, visit https://gerrit.ovirt.org/38214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd3bc6b716797583d3fc69fc69746bc3362eb58d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to