Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: multiple login messages ......................................................................
Patch Set 2: > > We went with red on the links because the blue was designed to be > > on a white background. > > > > But on second thought, it doesn't look too bad on gray: > > > > http://i.imgur.com/3IPo7gV.png > > yeah, I think that the blue over the gray background stands out > more than the red, hence the text is clearer [http://i.imgur.com/sjFEkCZ.png] > - I recommend going with the blue. > We asked the patternfly guys, and they gave us two different reds, the one we picked stood out most. I am color blind, but to me the red stands out more than the blue. I don't care that much which one pick. > > > > +1 for an icon. > > > > I think using the exact same font as the fields (maybe just > remove > > bold?) too. > > I think the bold looks good - need to keep in mind that the message > should really stand out in the screen (like the "Hey there is a > problem!" text in the PatternFly alert example) - this is what we > want the user to notice. but we can try both options and then > decide. -- To view, visit https://gerrit.ovirt.org/38214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd3bc6b716797583d3fc69fc69746bc3362eb58d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
