Moti Asayag has posted comments on this change. Change subject: engine: Validate change to gluster network ......................................................................
Patch Set 10: Code-Review+2 (2 comments) https://gerrit.ovirt.org/#/c/38177/10/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkClusterValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkClusterValidatorTest.java: Line 153: when(cluster.supportsGlusterService()).thenReturn(glusterService); Line 154: doReturn(brickDao).when(validator).getGlusterBrickDao(); Line 155: ArrayList<GlusterBrickEntity> list = new ArrayList<>(); Line 156: if (hasBricks) { Line 157: list.add(Mockito.mock(GlusterBrickEntity.class)); please statically import mock Line 158: } Line 159: when(brickDao.getAllByClusterAndNetworkId(any(Guid.class), any(Guid.class))).thenReturn(list); Line 160: assertThat(validator.glusterNetworkInUseAndUnset(cluster), expectedResult); Line 161: } https://gerrit.ovirt.org/#/c/38177/10/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java: Line 417: dao.updateBrickNetworkId(FixturesTool.GLUSTER_BRICK_UUID1, FixturesTool.NETWORK_ENGINE); Line 418: List<GlusterBrickEntity> bricks = Line 419: dao.getAllByClusterAndNetworkId(FixturesTool.GLUSTER_CLUSTER_ID, FixturesTool.NETWORK_ENGINE); Line 420: assertNotNull(bricks); Line 421: assertEquals(1, bricks.size()); could be replaced with assertFalse(bricks.isEmpty()) Line 422: assertEquals(FixturesTool.GLUSTER_BRICK_UUID1, bricks.get(0).getId()); Line 423: } -- To view, visit https://gerrit.ovirt.org/38177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57398b39783dbdc5ae9f79e7d32794f416c23116 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
