Moti Asayag has posted comments on this change. Change subject: engine: Validate change to gluster network ......................................................................
Patch Set 9: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/38177/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkClusterValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkClusterValidator.java: Line 28: public ValidationResult managementNetworkUnset() { Line 29: return ValidationResult.failWith(VdcBllMessages.ACTION_TYPE_FAILED_MANAGEMENT_NETWORK_UNSET). Line 30: when(oldNetworkCluster.isManagement() && !networkCluster.isManagement()); Line 31: } Line 32: please add unit-test Line 33: public ValidationResult glusterNetworkInUseAndUnset(VDSGroup cluster) { Line 34: return ValidationResult.failWith(VdcBllMessages.ACTION_TYPE_FAILED_MANAGEMENT_NETWORK_UNSET). Line 35: when(cluster.supportsGlusterService() && oldNetworkCluster.isGluster() && !networkCluster.isGluster() Line 36: && isGlusterNetworkInUse()); https://gerrit.ovirt.org/#/c/38177/9/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java: Line 184: brickRowMapper, Line 185: getCustomMapSqlParameterSource().addValue("task_id", taskId)); Line 186: } Line 187: Line 188: @Override please add dao test to cover the new stored procedure. Line 189: public List<GlusterBrickEntity> getAllByClusterAndNetworkId(Guid clusterId, Guid networkId) { Line 190: return getCallsHandler().executeReadList("GetBricksByClusterIdAndNetworkId", Line 191: brickRowMapper, Line 192: getCustomMapSqlParameterSource() -- To view, visit https://gerrit.ovirt.org/38177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57398b39783dbdc5ae9f79e7d32794f416c23116 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
