Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: generate cloud-init ISO image on fly ......................................................................
Patch Set 4: (5 comments) https://gerrit.ovirt.org/#/c/38811/4//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-17 00:30:05 +0100 Line 4: Commit: Simone Tiraboschi <stira...@redhat.com> Line 5: CommitDate: 2015-03-18 06:11:45 -0400 Line 6: Line 7: packaging: setup: generate cloud-init ISO image on fly you can drop the "on fly" part Line 8: Line 9: Ask a few question and generate cloud-init ISO image Line 10: on fly to customize an appliance. Line 11: Line 6: Line 7: packaging: setup: generate cloud-init ISO image on fly Line 8: Line 9: Ask a few question and generate cloud-init ISO image Line 10: on fly to customize an appliance. here to Line 11: Line 12: Change-Id: Iec4f409203e3a2d6da314208e9a0f422be00ce1b Line 13: Bug-Url: https://bugzilla.redhat.com/1198138 https://gerrit.ovirt.org/#/c/38811/4/src/ovirt_hosted_engine_setup/constants.py File src/ovirt_hosted_engine_setup/constants.py: Line 647: def CDROM(self): Line 648: return 'OVEHOSTED_VM/vmCDRom' Line 649: Line 650: GENERATE_CLOUD_INIT_ISO = 'OVEHOSTED_VM/cloudInitISO' Line 651: no reason for keeping new lines here Line 652: CLOUD_INIT_ROOTPWD = 'OVEHOSTED_VM/cloudinitRootPwd' Line 653: Line 654: CLOUD_INIT_INSTANCEHNAME = 'OVEHOSTED_VM/cloudinitInstanceHostName' Line 655: https://gerrit.ovirt.org/#/c/38811/4/src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py File src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py: Line 127: ohostedcons.VMEnv.GENERATE_CLOUD_INIT_ISO Line 128: ] == ohostedcons.Const.CLOUD_INIT_SKIP and Line 129: not self.environment[ Line 130: ohostedcons.VMEnv.GENERATE_CLOUD_INIT_ISO Line 131: ] == ohostedcons.Const.CLOUD_INIT_GENERATE not self.environment[ ohostedcons.VMEnv.GENERATE_CLOUD_INIT_ISO ] in ( ohostedcons.Const.CLOUD_INIT_SKIP, ohostedcons.Const.CLOUD_INIT_GENERATE, ) Line 132: ) Line 133: ) Line 134: def _customization(self): Line 135: mode = 'installation' https://gerrit.ovirt.org/#/c/38811/4/src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py File src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py: Line 49: Line 50: def __init__(self, context): Line 51: super(Plugin, self).__init__(context=context) Line 52: self._enable = False Line 53: self._directory_name = '' use None Line 54: Line 55: @plugin.event( Line 56: stage=plugin.Stages.STAGE_INIT, Line 57: ) -- To view, visit https://gerrit.ovirt.org/38811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec4f409203e3a2d6da314208e9a0f422be00ce1b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
