Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: generate cloud-init ISO image ......................................................................
Patch Set 7: -Code-Review (2 comments) https://gerrit.ovirt.org/#/c/38811/7/src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py File src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py: Line 18: # Line 19: Line 20: Line 21: """ Line 22: VM cdrom configuration plugin. VM cloud-init configuration plugin. Line 23: """ Line 24: Line 25: Line 26: import gettext Line 106: ] is not None or Line 107: self.environment[ Line 108: ohostedcons.VMEnv.CLOUD_INIT_INSTANCEHNAME Line 109: ] is not None Line 110: ): maybe: if (None, None, None) !=( self.environment[ohostedcons.VMEnv.GENERATE_CLOUD_INIT_ISO], self.environment[ohostedcons.VMEnv.CLOUD_INIT_ROOTPWD], self.environment[ohostedcons.VMEnv.CLOUD_INIT_INSTANCEHNAME] ) Line 111: interactive = False Line 112: Line 113: if interactive: Line 114: if self.dialog.queryString( -- To view, visit https://gerrit.ovirt.org/38811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec4f409203e3a2d6da314208e9a0f422be00ce1b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
