Shubhendu Tripathi has posted comments on this change. Change subject: webadmin: UI for gluster volume snapshot creation ......................................................................
Patch Set 30: (3 comments) https://gerrit.ovirt.org/#/c/35082/30/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java: Line 585: Line 586: public void postOnCreateSnapshot(VdcReturnValueBase returnValue, Line 587: GlusterVolumeSnapshotEntity snapshot, Line 588: GlusterVolumeSnapshotModel snapshotModel) { Line 589: getWindow(); > please remove this Done Line 590: Line 591: if (returnValue != null && returnValue.getSucceeded()) { Line 592: setWindow(null); Line 593: } Line 606: true); Line 607: snapshotModel.setHelpTag(HelpTag.edit_volume_snapshot_schedule); Line 608: snapshotModel.setHashName("edit_volume_snapshot_schedule"); //$NON-NLS-1$ Line 609: snapshotModel.setTitle(constants.editVolumeSnapshotScheduleTitle()); Line 610: setWindow(snapshotModel); > I don't see progress being shown. I mean snapshotModel.startProgress(null); Done Line 611: Line 612: AsyncDataProvider.getInstance().getVolumeSnapshotSchedule(new AsyncQuery(this, new INewAsyncCallback() { Line 613: Line 614: @Override https://gerrit.ovirt.org/#/c/35082/30/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java: Line 39: private EntityModel<Date> executionTime; Line 40: private ListModel<List<DayOfWeek>> daysOfWeek; Line 41: private ListModel<String> daysOfMonth; Line 42: Line 43: public GlusterVolumeSnapshotModel(List<GlusterVolumeSnapshotScheduleRecurrence> recurrenceOptions, > not required to be passed here. I am not sure why I had this before :)) Done Line 44: boolean generalTabVisible, Line 45: boolean scheduleTabVisible) { Line 46: init(recurrenceOptions); Line 47: setGeneralTabVisible(generalTabVisible); -- To view, visit https://gerrit.ovirt.org/35082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I823580ecb127e48e075c437668bfb19ff8ec4467 Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
