Shubhendu Tripathi has posted comments on this change. Change subject: webadmin: UI for gluster volume snapshot creation ......................................................................
Patch Set 28: (2 comments) https://gerrit.ovirt.org/#/c/35082/28/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java: Line 177: getDeleteSnapshotCommand().setIsExecutionAllowed(allowDelete); Line 178: getDeleteAllSnapshotsCommand().setIsExecutionAllowed(allowDeleteAll); Line 179: getActivateSnapshotCommand().setIsExecutionAllowed(allowActivate); Line 180: getDeactivateSnapshotCommand().setIsExecutionAllowed(allowDeactivate); Line 181: getNewSnapshotCommand().setIsAvailable(allowCreateSnapshot); > Actually this gets disabled only when volume is down else enabled always fo done Line 182: getEditSnapshotScheduleCommand().setIsAvailable(allowEditSnapshotSchedule); Line 183: } Line 184: Line 185: Line 178: getDeleteAllSnapshotsCommand().setIsExecutionAllowed(allowDeleteAll); Line 179: getActivateSnapshotCommand().setIsExecutionAllowed(allowActivate); Line 180: getDeactivateSnapshotCommand().setIsExecutionAllowed(allowDeactivate); Line 181: getNewSnapshotCommand().setIsAvailable(allowCreateSnapshot); Line 182: getEditSnapshotScheduleCommand().setIsAvailable(allowEditSnapshotSchedule); > Both New and Edit would be enabled if schedule exists. If a schedule does n done Line 183: } Line 184: Line 185: Line 186: @Override -- To view, visit https://gerrit.ovirt.org/35082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I823580ecb127e48e075c437668bfb19ff8ec4467 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
