Ramesh N has posted comments on this change. Change subject: engine: BLL command for gluster brick creation ......................................................................
Patch Set 14: (3 comments) https://gerrit.ovirt.org/#/c/36030/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java: Line 119: getInstance > Can we try using updateInBatch ?? Though its a list of devices here, I don't expect many devices in the list. Mostly it will be just one device. Do we still need to implement the batch mechanism? Line 150: getSucceeded > Else part should be ErrorType is AuditLogType.CREATE_GLUSTER_BRICK_FAILED. In Gluster related BLLs, its set by calling handleVdsError method. But here i am not inheriting from GlusterCommandBase. So I am directly returning from here. https://gerrit.ovirt.org/#/c/36030/14/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1188: ACTION_TYPE_FAILED_GLUSTER_VOLUME_SNAPSHOT_ALREADY_ACTIVATED=Cannot ${action} ${type}. Gluster volume snapshot ${snapname} is already activated. Line 1189: ACTION_TYPE_FAILED_GLUSTER_VOLUME_SNAPSHOT_ALREADY_DEACTIVATED=Cannot ${action} ${type}. Gluster volume snapshot ${snapname} is already de-activated. Line 1190: GLUSTER_TASKS_NOT_SUPPORTED_FOR_CLUSTER_LEVEL=Cannot ${action} ${type}. Gluster task management is not supported in compatibility version ${compatibilityVersion}. Line 1191: ACTION_TYPE_FAILED_STORAGE_PROVISIONING_NOT_SUPPORTED_BY_CLUSTER=Cannot ${action} ${type}. The selected cluster doesn't support Storage provisioning. Line 1192: ACTION_TYPE_FAILED_STORAGE_DEVICE_LOCKED=Cannot create Brick. Storage Device is locked. > Use place holders for action and entity type Done Line 1193: ACTION_TYPE_FAILED_STORAGE_DEVICE_REQUIRED=Cannot create Brick. At least one storage device is required. Line 1194: ACTION_TYPE_FAILED_DIFFERENT_STORAGE_DEVICE_TYPES_SELECTED=Cannot create Brick. Different types of storage devices are selected. Line 1195: ACTION_TYPE_FAILED_DEVICE_IS_ALREADY_IN_USE=Cannot create Brick. Storage Device ${storageDevice} is already in use. Line 1196: -- To view, visit https://gerrit.ovirt.org/36030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23fa314118324ca3f441d43852b8c57c54245308 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
