Ramesh N has posted comments on this change. Change subject: engine: BLL command for gluster brick creation ......................................................................
Patch Set 11: (2 comments) Added BLL test case https://gerrit.ovirt.org/#/c/36030/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java: Line 44: protected boolean canDoAction() { Line 45: VdsValidator validator = new VdsValidator(getVds()); Line 46: if (!validate(validator.isUp())) { Line 47: return false; Line 48: } > check if brick provisioning supported? Done Line 49: Line 50: String deviceType; Line 51: if (getParameters().getDisks().size() == 0) { Line 52: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DEVICE_REQUIRED); Line 121: LockMessagesMatchUtil.makeLockingPair(LockingGroup.HOST_STORAGE_DEVICES, Line 122: VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DEVICE_LOCKED)); Line 123: } Line 124: return locksMap; Line 125: } > You will need to override applyLockProperties() as well as default has Scop Done Line 126: Line 127: @Override Line 128: public AuditLogType getAuditLogTypeValue() { Line 129: return getSucceeded() ? AuditLogType.CREATE_GLUSTER_BRICK : AuditLogType.CREATE_GLUSTER_BRICK_FAILED; -- To view, visit https://gerrit.ovirt.org/36030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23fa314118324ca3f441d43852b8c57c54245308 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
