Shireesh Anjal has posted comments on this change.
Change subject: engine: check and peer probe gluster servers
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
Looks good, just one minor comment.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 209: try {
Line 210: glusterPeerProbe(upServer.getId(),
getVds().gethost_name());
Line 211: } catch (Exception e) {
Line 212: log.errorFormat("Could not peer probe the
gluster server {0}. Error: {1}",
Line 213: getVds().getvds_name(),
Better to log the host_name instead of vds_name
Line 214: e.getMessage());
Line 215: }
Line 216: }
Line 217: }
--
To view, visit http://gerrit.ovirt.org/7243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13c8de35ac596d89d2a9c631c4a8ef26996ea860
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
