Selvasundaram has posted comments on this change.
Change subject: engine: check and peer probe gluster servers
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 224: .getResourceManager()
Line 225: .RunVdsCommand(VDSCommandType.GlusterHostsList,
Line 226: new
VdsIdVDSCommandParametersBase(upServerId));
Line 227:
Line 228: if (!returnValue.getSucceeded()) {
I modified as "return values from 'getReturnValue()' if it is succeeded else
return empty array list instead of null".
Line 229:
getReturnValue().getFault().setError(returnValue.getVdsError().getCode());
Line 230:
getReturnValue().getFault().setMessage(returnValue.getVdsError().getMessage());
Line 231: AuditLogDirector.log(new AuditLogableBase(upServerId),
AuditLogType.GLUSTER_HOST_LIST_FAILED);
Line 232: }
--
To view, visit http://gerrit.ovirt.org/7243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13c8de35ac596d89d2a9c631c4a8ef26996ea860
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
