Alona Kaplan has posted comments on this change. Change subject: restapi: Setting and getting the host maintenance reason ......................................................................
Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/38314/2/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 213: maintenance_reason > As this is used to specify the reason for performing the action I think we Done Line 1943: <xs:element name="numa_supported" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1944: <xs:element name="live_snapshot_support" type="xs:boolean" minOccurs="0" maxOccurs="1" /> Line 1945: <xs:element ref="katello_errata" minOccurs="0" maxOccurs="1"/> Line 1946: <xs:element ref="external_host_provider" minOccurs="0" maxOccurs="1"/> Line 1947: <xs:element name="maintenance_reason" type="xs:string" minOccurs="0" maxOccurs="1"/> > The "status" element already has a "state" for maintenance, and has a "deta Done Line 1948: </xs:sequence> Line 1949: </xs:extension> Line 1950: </xs:complexContent> Line 1951: </xs:complexType> https://gerrit.ovirt.org/#/c/38314/2/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 2972: body: Line 2973: parameterType: Action Line 2974: signatures: Line 2975: - mandatoryArguments: {} Line 2976: optionalArguments: {action.async: 'xs:boolean', action.grace_period.expiry: 'xs:long', action.maintenanceReason: 'xs:string'} > The name here should be the same used in the XML schema, in this case "main Done Line 2977: description: deactivate the specified host Line 2978: urlparams: {} Line 2979: headers: Line 2980: Content-Type: {value: application/xml|json, required: true} https://gerrit.ovirt.org/#/c/38314/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java: Line 203: } > Put the maintenance reason in the "detail" element, like we currently do wi Done -- To view, visit https://gerrit.ovirt.org/38314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1c920672e68e5cb10d99ff3c4988ee4dade04f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
