Alona Kaplan has posted comments on this change. Change subject: restapi: Setting and getting the host maintenance reason ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/38314/3/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 2976: maintenanceReason > shouldn't it be maintenance_reason ? Done https://gerrit.ovirt.org/#/c/38314/3/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java: Line 249: return doAction(VdcActionType.MaintenanceNumberOfVdss, Line 250: new MaintenanceNumberOfVdssParameters(asList(guid), Line 251: false, Line 252: action.isSetMaintenanceReason() ? action.getMaintenanceReason() : null), Line 253: action); > can't the 2 lines be merged ? Done Line 254: } Line 255: Line 256: @Override Line 257: public Response forceSelectSPM(Action action) { -- To view, visit https://gerrit.ovirt.org/38314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1c920672e68e5cb10d99ff3c4988ee4dade04f3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
