Kanagaraj M has posted comments on this change. Change subject: webadmin: show storage devices in host ......................................................................
Patch Set 18: (5 comments) https://gerrit.ovirt.org/#/c/35315/18/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostStorageDevicesListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostStorageDevicesListModel.java: Line 24: HostStorageDevicesListModel This can be renamed to HostGlusterStorageDevicesListModel since this specific to gluster Line 76: @Override Line 77: protected void syncSearch() Line 78: { Line 79: if (getEntity() == null || getEntity().getStatus() != VDSStatus.Up) { Line 80: return; If the host is in Maintenance, this sub-tab will be empty? You should show the list of devices but disable the actions. Line 81: } Line 82: Line 83: AsyncDataProvider.getInstance().getStorageDevices(new AsyncQuery(this, new INewAsyncCallback() { Line 84: https://gerrit.ovirt.org/#/c/35315/18/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/WebAdminApplicationPlaces.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/WebAdminApplicationPlaces.java: Line 218: $ it could be "gluster_storage_devices" https://gerrit.ovirt.org/#/c/35315/18/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostStorageDevicesPresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostStorageDevicesPresenter.java: Line 27: SubTabHostStorageDevicesPresenter SubTabHostGlusterStorageDevicesPresenter https://gerrit.ovirt.org/#/c/35315/18/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostStorageDevicesView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostStorageDevicesView.java: Line 25: SubTabHostStorageDevicesView SubTabHostGlusterStorageDevicesView -- To view, visit https://gerrit.ovirt.org/35315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10da2f35012795de32367f295260ce9151c44909 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
