anmolbabu has posted comments on this change. Change subject: webadmin: show storage devices in host ......................................................................
Patch Set 15: (6 comments) https://gerrit.ovirt.org/#/c/35315/15/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java: Line 459: users("users", HelpTagType.UNKNOWN), //$NON-NLS-1$ Line 460: Line 461: view_gluster_hook("view_gluster_hook", HelpTagType.WEBADMIN, "[gluster] Clusters main tab -> Gluster Hooks sub tab -> 'Hook Content' dialog"), //$NON-NLS-1$ //$NON-NLS-2$ Line 462: Line 463: storage_device_list("storage_device_list", HelpTagType.UNKNOWN), //$NON-NLS-1$ HelpTagType.WEBADMIN ? Line 464: Line 465: virtual_machines("virtual_machines", HelpTagType.UNKNOWN), //$NON-NLS-1$ Line 466: Line 467: vm_import("vm_import", HelpTagType.UNKNOWN), //$NON-NLS-1$ https://gerrit.ovirt.org/#/c/35315/15/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostStorageDevicesListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostStorageDevicesListModel.java: Line 46: public HostStorageDevicesListModel() { Line 47: setTitle(ConstantsManager.getInstance().getConstants().storageDevices()); Line 48: setHelpTag(HelpTag.storage_device_list); Line 49: setHashName("storage_device_list"); //$NON-NLS-1$ Line 50: setSyncStorageDevicesCommand(new UICommand("Sync", this)); //$NON-NLS-1$ lower case first Line 51: setAvailableInModes(ApplicationMode.GlusterOnly); Line 52: } Line 53: Line 54: @Override Line 75: Line 76: @Override Line 77: protected void syncSearch() Line 78: { Line 79: if (getEntity() == null || getEntity().getStatus() != VDSStatus.Up) { where is entity set I mean where is setEntity invoked? Line 80: return; Line 81: } Line 82: Line 83: AsyncDataProvider.getInstance().getStorageDevices(new AsyncQuery(this, new INewAsyncCallback() { Line 93: } Line 94: Line 95: @Override Line 96: protected String getListName() { Line 97: return "HostDeviceListListModel"; //$NON-NLS-1$ HostStorageDevicesListModel ? Line 98: } Line 99: Line 100: private void syncStorageDevices() { Line 101: Frontend.getInstance().runAction(VdcActionType.SyncStorageDevices, new VdsActionParameters(getEntity().getId())); https://gerrit.ovirt.org/#/c/35315/15/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 2372: @Override Line 2373: protected String getListName() { Line 2374: return "HostListModel"; //$NON-NLS-1$ Line 2375: } Line 2376: Please undo this new line https://gerrit.ovirt.org/#/c/35315/15/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostStorageDevicesView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostStorageDevicesView.java: Line 69: if (object.getSize() != null){ Line 70: Pair<SizeUnit, Double> convertedSize = SizeConverter.autoConvert(object.getSize(), SizeUnit.MB); Line 71: return formatSize(convertedSize.getSecond()) + " " + convertedSize.getFirst().toString(); //$NON-NLS-1$ Line 72: } else { Line 73: return ""; //$NON-NLS-1$ probably constants.empty() ? Line 74: } Line 75: Line 76: } Line 77: }; -- To view, visit https://gerrit.ovirt.org/35315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10da2f35012795de32367f295260ce9151c44909 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
