Martin Peřina has posted comments on this change.
Change subject: aaa: Remove userId parameter from LogoutUserCommand
......................................................................
Patch Set 1:
> I think that the restapi filter should call terminate session and not logoff
> and this will make the flow consistent.
Well, RestApiSessionMgmtFilter knows only engineSessionId that is passed from
client. If RestApiSessionMgmtFilter should call TerminateSessionCommand, then
it's flow should be changed to:
1. Ask Backend to get sessionDbId for provided engineSessionId
2. Call TerminateSessionCommand
But IMO it's not logical for these reasons:
1. There's no admin user which initiated logout of REST API user in
RestApiSessionMgmtFilter, there's just user that is logged-in and using
REST API -> calling standard logoff of the user based on its engineSessionId
makes sense
2. I don't see a reason for all REST API logouts to get sessionDbId first
and after that call TerminateSession
So personally I would merge this patch as is and I would rebase Yevgeny's
patches on top of it (I can do this by myself, no problem).
I can investigate the removal of DBUser parameter from
GenericApiGWTService.logoff() method as Yevgeny suggested in different patch.
Agreed?
--
To view, visit https://gerrit.ovirt.org/38403
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia33c7dfd908c68ac06b717c0452e3de4564f35a7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
