Martin Peřina has posted comments on this change. Change subject: aaa: Remove userId parameter from LogoutUserCommand ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38403/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutBySessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutBySessionCommand.java: Line 26 Line 27 Line 28 Line 29 Line 30 > so why do you need to explicitly set the session id here? maybe I do not un 1. RestApiSessionMgmtFilter calls LogoutBySession command with sessionId specified in parameters 2. Inside LogoutBySession command we take sessionId received in parameters and call Backend.logoff() with parameters that contains this sessionId 3. Backend.logoff() calls LogoutUser command with parameters that also contains this sessionId That's the chain. But IMO we can merge LogoutBySession and LogoutUser command together as both are using only sessionId and not userId after changes contained in this patch. I've also looked at VdcActionParameters.setSessionId() usage and commands that executes other subcommand passes this sessionId as parameter so subcommand will be executed with the same parent command context as main command. -- To view, visit https://gerrit.ovirt.org/38403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia33c7dfd908c68ac06b717c0452e3de4564f35a7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
