Oved Ourfali has posted comments on this change.

Change subject: engine: add TerminateSession command
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38382/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java:

Line 37:     @Override
Line 38:     protected void executeCommand() {
Line 39:         LogoutUserParameters params = new 
LogoutUserParameters(user.getId());
Line 40:         params.setSessionId(sessionId);
Line 41:         setReturnValue(Backend.getInstance().logoff(params));
> if cleaning up the code base reduce the complexity of newly added changes, 
Okay. If we get to some closure soon then great. If not, we'll push it as is, 
and change it after Martin finishes.
Line 42:     }
Line 43: 
Line 44:     @Override
Line 45:     protected boolean isUserAuthorizedToRunAction() {


-- 
To view, visit https://gerrit.ovirt.org/38382
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdc71abbd51d2eb01b2b3d9c877626d57d68d23
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to