Oved Ourfali has posted comments on this change. Change subject: engine: add TerminateSession command ......................................................................
Patch Set 1: (2 comments) overall looks good. one question inline https://gerrit.ovirt.org/#/c/38382/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java: Line 37: @Override Line 38: protected void executeCommand() { Line 39: LogoutUserParameters params = new LogoutUserParameters(user.getId()); Line 40: params.setSessionId(sessionId); Line 41: setReturnValue(Backend.getInstance().logoff(params)); > there is no reason to add something complex if the effort of cleaning the i Indeed not part of this patch, and the week is almost over. Up to Yevgeny whether he wants to do that or not. Line 42: } Line 43: Line 44: @Override Line 45: protected boolean isUserAuthorizedToRunAction() { Line 47: } Line 48: Line 49: @Override Line 50: public List<PermissionSubject> getPermissionCheckSubjects() { Line 51: return Collections.emptyList(); Why not to require super user on system in order to run that, instead of overwriting isUserAuthorizedToRunAction? Line 52: } -- To view, visit https://gerrit.ovirt.org/38382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebdc71abbd51d2eb01b2b3d9c877626d57d68d23 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
