Oved Ourfali has posted comments on this change. Change subject: core: Introduce SingleAgentPmActionExecutor ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/38358/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-03-04 09:44:39 +0100 Line 6: Line 7: core: Introduce SingleAgentPmActionExecutor Line 8: Line 9: Introduces SignleAgentPmActionExecutor which is responsible to execute s/signle/single Line 10: power management action on the host using signle fence agent. It Line 11: contains logic to get status of the host or to start/stop the host and Line 12: to verify requested status using FenceAgentExecutor. Line 13: Line 6: Line 7: core: Introduce SingleAgentPmActionExecutor Line 8: Line 9: Introduces SignleAgentPmActionExecutor which is responsible to execute Line 10: power management action on the host using signle fence agent. It s/signle/single Line 11: contains logic to get status of the host or to start/stop the host and Line 12: to verify requested status using FenceAgentExecutor. Line 13: Line 14: Change-Id: I95958b4821fa8f55ee8913e926f9528ae56e20e8 https://gerrit.ovirt.org/#/c/38358/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentPmActionExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentPmActionExecutor.java: Line 15: import org.slf4j.Logger; Line 16: import org.slf4j.LoggerFactory; Line 17: Line 18: /** Line 19: * Manages fence execution for the host using specified fence agent You're doing here fencing.. so shouldn't we call it: SingleAgentFencingActionExecutor? Line 20: */ Line 21: public class SingleAgentPmActionExecutor { Line 22: private static final Logger log = LoggerFactory.getLogger(SingleAgentPmActionExecutor.class); Line 23: -- To view, visit https://gerrit.ovirt.org/38358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95958b4821fa8f55ee8913e926f9528ae56e20e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
