Liron Aravot has posted comments on this change.

Change subject: restapi: Extending disk editing when adding a new template.
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/37808/8/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java:

Line 161:                     continue;
Line 162:                 }
Line 163: 
Line 164:                 DiskImage destinationDisk = (DiskImage) 
DiskMapper.map(disk, sourceDisk);
Line 165:                 if (isTemplateGeneralStorageDomainSet) {
on fixing that thing, we are creating a problem and extending an existing 
problem - when general storage domain is set the command will fail because of 
wrong disk profile (disk profile is "related" to a domain, here we override the 
domain while using the old disk profile - which will lead to CDA failure.
Line 166:                     destinationDisk.setStorageIds(new 
ArrayList<>(Arrays.asList(storageDomainId)));
Line 167:                 }
Line 168:                 
destinationTemplateDiskMap.put(destinationDisk.getId(), destinationDisk);
Line 169:             }


-- 
To view, visit https://gerrit.ovirt.org/37808
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0baf4e5bd7233fbc4eab2f1f671b8b15e08ba03
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to