Maor Lipchuk has posted comments on this change. Change subject: restapi: Extending disk editing when adding a new template. ......................................................................
Patch Set 8: (3 comments) minor style comments, but generally looks good. Is there a test for this? https://gerrit.ovirt.org/#/c/37808/8/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java: Line 145: protected Please use formatter Line 178: queryVMDiskList /s/queryVMDiskList/queryVmDisksMap Line 175: return disk.getDiskStorageType() == org.ovirt.engine.core.common.businessentities.Disk.DiskStorageType.IMAGE; Line 176: } Line 177: Line 178: private Map<Guid, org.ovirt.engine.core.common.businessentities.Disk> queryVMDiskList(VM vm) { Line 179: List<org.ovirt.engine.core.common.businessentities.Disk>vmDisks = getBackendCollection(org.ovirt.engine.core.common.businessentities.Disk.class, formatter Line 180: VdcQueryType.GetAllDisksByVmId, Line 181: new IdQueryParameters(asGuid(vm.getId()))); Line 182: return Entities.businessEntitiesById(vmDisks); Line 183: } -- To view, visit https://gerrit.ovirt.org/37808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0baf4e5bd7233fbc4eab2f1f671b8b15e08ba03 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
