Maor Lipchuk has posted comments on this change. Change subject: core: determine wether domain monitoring result is actual ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38039/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java: Line 1232: boolean > because that way you'll have to add that condition in each place. when you I think this is a classic case of enum, since boolean does not cover all the options and might be confusing. alternatively, if you don't want to use enum, I would change the API to be more specific, as follow: valid() --> actualAndValid() invalid() --> actualAndInvalid() -- To view, visit https://gerrit.ovirt.org/38039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddbba94d81694bd6cb1ce3648872eb81182a50ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
