Liron Aravot has posted comments on this change. Change subject: core: determine wether domain monitoring result is actual ......................................................................
Patch Set 2: (6 comments) https://gerrit.ovirt.org/#/c/38039/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java: Line 479: reportWhetherDomainMonitoringResultIsActual > This is a boolean method, it does not report anything all the methods in this class return a boolean, while their name is the name of the config value - therefore i'll keep the name as is to align with the rest of the methods. as for the config value name, i prefer to keep the current name as it's more informative and inituative then the name you suggested (ActualResultForDomainMonitorSupported) which may confuse (what is "actual result") - do you have other suggestion? I don't mind to change it. https://gerrit.ovirt.org/#/c/38039/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 2040: ReportWhetherDomainMonitoringResultIsActual > Please add Supported or Enabled at the end of the name (unification reasons the names aren't unified - take a look please at the values here.. (for example, "ImportDataStorageDomain"/"ReportedDisksLogicalNames" :) ). https://gerrit.ovirt.org/#/c/38039/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java: Line 1225: return actual() && valid; Line 1226: } Line 1227: Line 1228: public boolean invalid() { Line 1229: return actual() && !valid; > so a resposnse can be neither valid nor invalid if it isn't actual, right? yes, when the result isn't actual..it's neither valid/invalid. Line 1230: } Line 1231: Line 1232: public boolean actual() {return this != NOT_ACTUAL;} Line 1233: } Line 1232: boolean > same question as Allon asked, I'm also didn't follow what will happened if yes, both will be false. Line 1234: Line 1235: private DomainMonitoringResult analyzeDomainReport(VDSDomainsData tempData, StoragePool storagePool, boolean isLog) { Line 1236: if (!tempData.isActual() && Line 1237: FeatureSupported.reportWhetherDomainMonitoringResultIsActual(storagePool.getCompatibilityVersion())) { Line 1238: log.error("Domain '{}' report isn't an actual report", > +1, I would also add more information about it, since "actual" is not that i'll change it to warn. I prefer to not add "Domain monitor has not yet monitored Domain" becasue it's info that the engine shouldn't know about - it just knows if the result is actual or not, not why. Line 1239: getDomainIdTuple(tempData.getDomainId())); Line 1240: return DomainMonitoringResult.NOT_ACTUAL; Line 1241: } Line 1242: https://gerrit.ovirt.org/#/c/38039/2/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 211: select fn_db_add_config_value_for_versions_up_to('HotPlugDiskSnapshotSupported', 'false', '3.2'); Line 212: select fn_db_add_config_value_for_versions_up_to('GetFileStats', 'false', '3.3'); Line 213: select fn_db_add_config_value_for_versions_up_to('DefaultRouteSupported', 'false', '3.3'); Line 214: select fn_db_add_config_value_for_versions_up_to('SerialNumberPolicySupported', 'false', '3.4'); Line 215: select fn_db_add_config_value_for_versions_up_to('ReportWhetherDomainMonitoringResultIsActual', 'false', '3.5'); > Are you sure this should be 3.5 and not 3.4? thought that we'll target this fix for 3.6. changing. Line 216: Line 217: select fn_db_add_config_value_for_versions_up_to('OvfStoreOnAnyDomain', 'false', '3.4'); Line 218: select fn_db_add_config_value_for_versions_up_to('BootMenuSupported', 'false', '3.4'); Line 219: -- To view, visit https://gerrit.ovirt.org/38039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddbba94d81694bd6cb1ce3648872eb81182a50ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
