Sahina Bose has posted comments on this change. Change subject: engine: Enhance brick to support storage network ......................................................................
Patch Set 6: (4 comments) patchset to follow https://gerrit.ovirt.org/#/c/37558/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java: Line 170: Line 171: return true; Line 172: } Line 173: Line 174: private Network getGlusterNetworkId(VdsStatic server) { > getGlusterNetwork Done Line 175: List<Network> allNetworksInCluster = getNetworkDAO().getAllForCluster(server.getVdsGroupId()); Line 176: Line 177: for (Network network : allNetworksInCluster) { Line 178: if (network.getCluster().isGluster()) { Line 175: List<Network> allNetworksInCluster = getNetworkDAO().getAllForCluster(server.getVdsGroupId()); Line 176: Line 177: for (Network network : allNetworksInCluster) { Line 178: if (network.getCluster().isGluster()) { Line 179: return network; > Is it possible to cache this? Yes..within a cluster it would be the same network. Will cache it. Line 180: } Line 181: } Line 182: return null; Line 183: } Line 229: return getDbFacade().getInterfaceDao(); Line 230: } Line 231: Line 232: @Override Line 233: protected NetworkDao getNetworkDAO() { > is this overriding required? yes..visibility for the Junit test Line 234: // TODO Auto-generated method stub Line 235: return super.getNetworkDAO(); Line 236: } Line 237: https://gerrit.ovirt.org/#/c/37558/6/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 3027: FROM gluster_volume_bricks Line 3028: INNER JOIN vds_static ON vds_static.vds_id = gluster_volume_bricks.server_id Line 3029: INNER JOIN gluster_volumes ON gluster_volumes.id = gluster_volume_bricks.volume_id Line 3030: LEFT OUTER JOIN network on network.id = gluster_volume_bricks.network_id Line 3031: LEFT OUTER JOIN vds_interface ON vds_interface.vds_id = gluster_volume_bricks.server_id > TWS Done Line 3032: AND vds_interface.network_name = network.name ; Line 3033: Line 3034: CREATE Line 3035: OR REPLACE VIEW gluster_volume_task_steps AS -- To view, visit https://gerrit.ovirt.org/37558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9749febf721172a09ddce756c0eeb745a9502e1a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
