Kanagaraj M has posted comments on this change. Change subject: engine: Enhance brick to support storage network ......................................................................
Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/37558/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java: Line 170: Line 171: return true; Line 172: } Line 173: Line 174: private Network getGlusterNetworkId(VdsStatic server) { getGlusterNetwork Line 175: List<Network> allNetworksInCluster = getNetworkDAO().getAllForCluster(server.getVdsGroupId()); Line 176: Line 177: for (Network network : allNetworksInCluster) { Line 178: if (network.getCluster().isGluster()) { Line 175: List<Network> allNetworksInCluster = getNetworkDAO().getAllForCluster(server.getVdsGroupId()); Line 176: Line 177: for (Network network : allNetworksInCluster) { Line 178: if (network.getCluster().isGluster()) { Line 179: return network; Is it possible to cache this? You are anyway using the same network for all the bricks? may be not? Line 180: } Line 181: } Line 182: return null; Line 183: } Line 229: return getDbFacade().getInterfaceDao(); Line 230: } Line 231: Line 232: @Override Line 233: protected NetworkDao getNetworkDAO() { is this overriding required? Line 234: // TODO Auto-generated method stub Line 235: return super.getNetworkDAO(); Line 236: } Line 237: -- To view, visit https://gerrit.ovirt.org/37558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9749febf721172a09ddce756c0eeb745a9502e1a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
