Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL command to set volume snapshot config ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/36294/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterVolumeSnapshotConfigCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterVolumeSnapshotConfigCommand.java: Line 22: import org.ovirt.engine.core.compat.Guid; Line 23: import org.ovirt.engine.core.dal.dbbroker.DbFacade; Line 24: import org.ovirt.engine.core.dao.gluster.GlusterVolumeSnapshotConfigDao; Line 25: Line 26: public class UpdateGlusterVolumeSnapshotConfigCommand extends GlusterCommandBase<UpdateGlusterVolumeSnapshotConfigParameters> { > done Sorry, we cannot extend from GlusterSnapshotCommandBase, as the base class canDoActions fails if the volumeId is null. And in this BLL is params are being set for cluster, the volumeId would be passed as null from UI. Line 27: Line 28: private boolean updatesSuccessful; Line 29: private List<String> failedCfgs; Line 30: -- To view, visit http://gerrit.ovirt.org/36294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37b6f4dd02ca4258e5e40e7da11f0a657ac6b330 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
