Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL command to set volume snapshot config ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/36294/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/UpdateGlusterVolumeSnapshotConfigParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/UpdateGlusterVolumeSnapshotConfigParameters.java: Line 9: public class UpdateGlusterVolumeSnapshotConfigParameters extends VdcActionParametersBase { Line 10: private static final long serialVersionUID = 2015321730118872977L; Line 11: Line 12: private Guid clusterId; Line 13: // Nullable, so not extending the class from GlusterVolumeParameters > Failure would be in the command, because you're checking for volumeId. How Yes correct. Parameters class we can extend but BLL cannot extend from GlusterVolumeSnapshotCommandBase as canDoAction is base class would fails if volumeId is null. But here volumeId can be null if we are setting only cluster params. Line 14: private Guid volumeId; Line 15: private List<GlusterVolumeSnapshotConfig> configParams; Line 16: Line 17: public UpdateGlusterVolumeSnapshotConfigParameters() { -- To view, visit http://gerrit.ovirt.org/36294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37b6f4dd02ca4258e5e40e7da11f0a657ac6b330 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
